This repository has been archived by the owner on Aug 13, 2024. It is now read-only.
Allow scales to be loaded via MCDF files #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I havent had the time/motivation to check on it, will trial this today and release the fix asap, people will be very happy haha :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue since the temp profiles loaded via IPC are done via an actor address not by name.
For this case, what has been done is when an actor is created, the profile contains the actor address, and if that is set and the actors match in the
CharacterProfile.AppliesTo(Dalamud.Game.ClientState.Objects.Types.GameObject)call, the profile is marked as applicable.